Skip to content

Commit

Permalink
Cleaned makie code
Browse files Browse the repository at this point in the history
- comments
- removed superfluos display calls, no popping up of windows in pluto
  • Loading branch information
j-fu committed May 5, 2021
1 parent 18b6a26 commit b8752bc
Show file tree
Hide file tree
Showing 4 changed files with 300 additions and 247 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GridVisualize"
uuid = "5eed8a63-0fb0-45eb-886d-8d5a387d12b8"
authors = ["Juergen Fuhrmann <[email protected]>"]
version = "0.2.2"
version = "0.2.3"

[deps]
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ The main supported backends are GLMakie and PyPlot.
- 'i' means some level of interactive control
- '(y)' means avaiability only on rectangular resp. cuboid grids.

| | PyPlot | *Makie | Plots | VTKView |
|-----------:|--------|--------|-------|---------|
| scalar, 1D | y | y | y | y |
| grid, 1D | y | y | y | n |
| scalar, 2D | y | y,i | (y) | y,i |
| grid, 2D | y | y,i | (y) | y,i |
| scalar, 3D | y | y,i | no | y,i |
| grid, 3D | y | y,i | no | y,i |

| | PyPlot | GLMakie | Plots | VTKView |
|------------+--------+---------+-------+---------|
| scalar, 1D | y | y | y | y |
| grid, 1D | y | y | y | n |
| scalar, 2D | y | y,i | (y) | y,i |
| grid, 2D | y | y,i | (y) | y,i |
| scalar, 3D | y | y,i | no | y,i |
| grid, 3D | y | y,i | no | y,i |


For 2D plots, CairoMakie works as well.

### [PyPlot](https://github.com/JuliaPy/PyPlot.jl):
<img src="docs/src/assets/multiscene_pyplot.png?raw=true" width=300/>
Expand Down
2 changes: 1 addition & 1 deletion src/dispatch.jl
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ default_plot_kwargs()=OrderedDict{Symbol,Pair{Any,String}}(
:clear => Pair(true,"Clear plot before new plot."),
:layout => Pair((1,1),"Layout of plots in window"),
:resolution => Pair((500,500),"Plot window resolution"),
:legend => Pair(:none,"Legend (position): one of [:none, :best, :lt, :ct, :rt, :lc, :rc, :lb, :cb, :rb]"),
:title => Pair("","Plot title"),
:xlimits => Pair((1,-1),"x limits"),
:ylimits => Pair((1,-1),"y limits"),
Expand All @@ -261,7 +262,6 @@ default_plot_kwargs()=OrderedDict{Symbol,Pair{Any,String}}(
:color => Pair((0.0,0.0,0.0),"1D plot line color"),
:cellwise => Pair(false,"1D plots cellwise can be slow)"),
:label => Pair("","1D plot label"),
:legend => Pair(:none,"Legend (position): one of [:none, :best, :lt, :ct, :rt, :lc, :rc, :lb, :cb, :rb]"),
:isolines => Pair(11,"2D contour plot: number of isolines"),
:elevation => Pair(0.0,"2D plot height factor for elevation"),
:colorlevels => Pair(51,"2D/3D contour plot: number of color levels"),
Expand Down
Loading

2 comments on commit b8752bc

@j-fu
Copy link
Member Author

@j-fu j-fu commented on b8752bc May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/36148

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.3 -m "<description of version>" b8752bcdbd9e88d94c91038fdf0ba851ba62564f
git push origin v0.2.3

Please sign in to comment.