Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discontinuous cellwise plots #22

Closed
wants to merge 0 commits into from
Closed

Conversation

chmerdon
Copy link
Member

cellwise switch is now handled in 2d Makie scalarplot (isolines are switched off for now, though)

@codecov-commenter
Copy link

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (13785e5) 39.54% compared to head (b8d1d59) 39.03%.

Files Patch % Lines
src/makie.jl 37.25% 32 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   39.54%   39.03%   -0.52%     
==========================================
  Files          10       10              
  Lines        1970     2001      +31     
==========================================
+ Hits          779      781       +2     
- Misses       1191     1220      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu
Copy link
Member

j-fu commented Dec 13, 2023

I am thinking about the API here.

Some thougts:

  • With the techniques at hand we probably can handle: P0, P1, P1broken, and instead of :cellwise we could say e.g. space=:P1broken
  • For these three cases we could detect the situation automatically from the length of the func array.
  • We might try to be consistent with the vision of a GridVisualizeExtendableFEMBaseExt extension. I think the automatic approch would be consistent with that.

@chmerdon
Copy link
Member Author

Yes, I like that idea! While we are at it we can also do space P2 and P2broken.

@j-fu j-fu mentioned this pull request Jan 25, 2024
@j-fu j-fu marked this pull request as draft November 25, 2024 12:53
@chmerdon chmerdon closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants