WebUI Enhancements and network setup page #42
Conversation
remove master branch (not needed + accidental commit to wrong branch)
|
@Orbitix |
|
@joshschmelzle html file added. should work now! |
|
@joshschmelzle I am away this weekend so I can't push anything untill Sunday. The git repo on my pi didn't pick up new files, only the modified ones so that's why so many are missing. |
Orbitix
changed the title
|
Is there more to be done to this to prepare for merge |
|
@Orbitix is there anything on your side remaining to commit? I can look early next week and get this merged for Prague. |
|
@joshschmelzle everything on my end is commited and working. The code probably just needs to be cleaned up a bit, but other than that it should be fine |
|
@joshschmelzle I have pushed the change that fixes the webui crash when nginx times out, so it will just return "Internal Server Error" in the message box on the network setup page instead of just going to a 500 page. Is there anything else that needs doing with webui or is it all good to hand over to you? |
|
I can take a look either late tonight or tomorrow |
|
Hey @Orbitix, thanks for taking the time on this PR. I started reviewing your PR last night and noticed a few issues that are causing errors and can easily break when used in production. There are quite a few areas that need polishing, and because of the size of the changes, it's taking me longer than expected to go through everything in detail. I really appreciate the effort you're putting in, but as it stands, the code isn’t quite ready to be merged. Before we move forward, I wanted to ask—how comfortable are you with receiving feedback and making revisions on this PR? I'd be happy to go through the changes with you and guide you on how to improve them. However, this will certainly delay these changes getting into the Prague release. Alternatively, if you'd prefer, I can take it over from here and incorporate the changes myself. Let me know how you'd like to proceed, and thanks again for all your effort on this. |
|
Thanks for the response @joshschmelzle, I would prefer if we could go through the issues together, as I feel it is valuable for me to learn how to resolve these kind of problems, and also prevent them in the first place as this is all still quite new to me, and I'm not very confident in my code as I don't completely know what I'm doing when it comes to robust and production-ready code. I would also like the changes to be in the Prague release, as they link with Ben's core changes, so if needed I am fine with you taking over and finishing it if we run out of time. I am also really grateful for your support and time with helping me learn and become a better coder, it is really valuable experience to learn how contributing to an active project works, and for me and any future jobs I may be developing in. I may not be able to respond with changes very quickly because of school and studies, but I will whenever I have time. |
|
As discussed on the team meeting today, I plan on making some more changes to this PR and also in the process attempt to set some guidelines on how to handle async scenarios with htmx. |
|
Alright thanks, that would help a lot as I don't really know how to use htmx |
Adds a new page under network called 'setup', which contains a form that interacts with wlanpi-core api to set the wpa-supplicant. future UI changes will be made to make it look better and less crowded.
Below it there is an iframe that shows a table from the interface scan results. this is asynchronous so the page loads and doesn't wait for this first.
There is also a pill in the navbar that shows the current mode that the wlanpi is in, in the future this will be a selector to change the mode from the UI, which I have already designed but commented out.