Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.11 compatibility #157

Merged
merged 1 commit into from
Aug 24, 2023
Merged

python3.11 compatibility #157

merged 1 commit into from
Aug 24, 2023

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Aug 24, 2023

Python 3.11 compatibility

Description

  • Add Python 3.11 classifier into setup.py
  • Add Python 3.11 into Github actions CI

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • SMACT installed in new python 3.11 environment and pytest was used to check that the installation produced no errors
  • Github actions CI showed that SMACT works in Python 3.11

Test Configuration:

  • Python version: 3.11
  • Operating System: WSL2(Ubuntu)

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@AntObi AntObi merged commit 1b7cac5 into master Aug 24, 2023
13 checks passed
@AntObi AntObi deleted the python_311 branch August 24, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AntObi