Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal_space #189

Merged
merged 2 commits into from
Dec 6, 2023
Merged

crystal_space #189

merged 2 commits into from
Dec 6, 2023

Conversation

hspark1212
Copy link
Collaborator

Crystal Space tutorials

Description

This pull request involve an example of screening with the SMCAT filter to explore chemical space in compositions. The tutorials will be placed at Crystal_Space directory.

Type of change

N/A

How Has This Been Tested?

I tested running the code in the Planck server.

Test Configuration:

  • Python version: 3.8
  • Operating System: Centos 7

Reviewers

@aronwalsh @AntObi

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (133b065) 72.80% compared to head (1bda7be) 72.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files          24       24           
  Lines        1945     1945           
=======================================
  Hits         1416     1416           
  Misses        529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntObi
Copy link
Collaborator

AntObi commented Dec 6, 2023

All tests pass, and the code & notebooks are nicely documented. Happy to merge!

@AntObi AntObi merged commit 7d1ee94 into master Dec 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants