-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add softmax and selectivity #193
📝 Add softmax and selectivity #193
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## chloeLeeDOper #193 +/- ##
=================================================
+ Coverage 72.71% 73.04% +0.32%
=================================================
Files 24 24
Lines 1913 1966 +53
=================================================
+ Hits 1391 1436 +45
- Misses 522 530 +8 ☔ View full report in Codecov by Sentry. |
HI @JiwooChloeLee, I've fixed the issue with the docs not building and some of the tests failing by merging the latest commits in SMACT into your fork. You'll have to update your own local installation to make sure it has all the changes that I've done. Before I can merge this I need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for requested changes
) -> dict: | ||
""" | ||
Args: | ||
num_dopants (int): The number of suggestions to return for n- and p-type dopants. | ||
apply_softmax (bool): Whether to apply softmax to probabilities. (default = True) | ||
get_selectivity (bool): Whether |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc string incomplete for the get_selectivity
argument
|
||
def get_dopants( | ||
self, | ||
num_dopants: int = 5, | ||
self, num_dopants: int = 5, apply_softmax=False, get_selectivity=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test needs to be written for when apply_softmax
is set to True
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Added softmax function and Selectivity in doper.py
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Reviewers
@mention individuals who you specifically want to involve in the discussion for this pull request and mention why they are needed in the discussion/why they are needed to review the pull request.
Checklist: