Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Web3Inbox CORS Support #172

Merged
merged 14 commits into from
Aug 2, 2023
Merged

feat: Web3Inbox CORS Support #172

merged 14 commits into from
Aug 2, 2023

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Aug 2, 2023

Description

Adds CORS headers for W3I's FCM Web Push use case

How Has This Been Tested?

N/a

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@HarryET HarryET requested review from xav, arein and devceline August 2, 2023 08:40
@HarryET HarryET self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

src/lib.rs Outdated Show resolved Hide resolved
Copy link

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarryET HarryET merged commit b16b97d into main Aug 2, 2023
3 of 4 checks passed
@chris13524 chris13524 deleted the feat/cors-w3i branch October 23, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants