Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only log SQL statements when at trace #184

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Aug 28, 2023

Description

Makes sure we dont have weird error/debug logs

Resolves #181

How Has This Been Tested?

N/a changes log levels

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@HarryET HarryET self-assigned this Aug 28, 2023
Copy link
Contributor

@xav xav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the Clippy comments too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we won't use this, let's remove it instead of commenting it out. Otherwise, add a TODO comment please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from testing and shouldn't have been included

@HarryET HarryET merged commit e1153a9 into main Aug 28, 2023
5 of 6 checks passed
@HarryET
Copy link
Contributor Author

HarryET commented Aug 28, 2023

Local git was commiting to main so this was pushed into main, fixed main as well as my local git

@HarryET HarryET deleted the chore/sqlx-logs branch August 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: logging broken
2 participants