Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic 2024 #1257

Draft
wants to merge 984 commits into
base: dev
Choose a base branch
from
Draft

Magic 2024 #1257

wants to merge 984 commits into from
+92,961 −3,572

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Nov 28, 2023 •
edited by helloruhe
Loading

copied description form Meme PR. Updated to the most current patch

Changelog:

  • Added Magic Lifestyles.
  • Added effects to sorcerer traits
  • Changed localisation for magical doctrine parameters
  • Close Class adaptation #5

General TODO:

  • Restrict focus selection
  • Gender doctrine loc
  • Focus buffs / loc
  • Adapt vanilla events
  • Restrict lifestyle selection
  • Give magic resistance even if magic usage is secret
  • Fix Freezerburn perk that Dione broke
  • Fix chances for army/knight targeting spells (currently one roll for entire army, should be one roll per target)
  • Fix spell reflect for new schemes
  • Apply Divine Storm to armies and travelers passing through the area
  • Banshee, Ghoul, Vampire, Revenant trait modifiers and balancing
  • Epidemic traits balancing
  • Epidemic modifiers
  • Fix dodging, hit, and resist TTs
  • Fix add or increase burn/frostbite
  • River Spirit's Rage cultural localization
  • Cancel spell cast when all targets die or destroyed
  • Notification when spell is off cooldown
  • Fix court mage + integrate with new court position system
  • Add magic modifiers to existing artifacts
  • Add magic event options / modifiers to exisitng WC content
  • Make sure all magic illnesses / injuries use vanilla treatment system
  • Unlearn spells when resetting perks
  • Add monitoring for spells that target lands

Art TODO:

  • Magic decision backgrounds
  • Fire ritual icons
  • Frostbite decal
  • Frostbite trait icon
  • Ice Block trait icon
  • Frost/snowflake modifier icon
  • Ice block static model
  • Master Pyromancer trait icon
  • Master Cryomancer trait icon
  • Polymorph trait icon
  • Arcane ritual icons
  • Light ritual icons
  • Abomination 3D static model
  • Banshee appearance
  • Ghoul 3D static model
  • Vampire appearance
  • Vampire trait icon
  • Revenant trait icon
  • Frost Fever trait icon
  • Crypt Fever trait icon
  • Blood Plague trait icon
  • Death ritual icons
  • Water ritual icons
  • Hibernation trait icon

Lifestyles TODO:

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

How to test:

  • Basically, it's 2nd round of what have been tested in Magic doctrines #120 - check that lore character can pick correct focuses in correct lifestyles.
  • Ignore perks, they are not ready yet.
  • Use add_lifestyle_xp_all console command to get exp for all lifestyles

helloruhe and others added 30 commits January 1, 2025 03:07
@helloruhe
Small QoL Fixes
34ef0bb
@helloruhe
clear targets when selecting new spell only
c3a3e9a
@helloruhe
reccomended target selection
f6e75af
@helloruhe
Find more targets using char finder
0ae81b9
@helloruhe
Eligible only toggle
662b598
@helloruhe
add yourself to rec target list
badc54a
@helloruhe
more reccomended target fixes
1836449
@helloruhe
Close province window when choosing new spell/class/target
a658f26
@helloruhe
more eligible target improvements
71a7a33
@helloruhe
cap magical prowess reduction
80a50c9
@helloruhe
make class selection prettier
a68ce23
@helloruhe
Change spell selection GUI
688a288
@helloruhe
Change character selection box
5005ec2
@helloruhe
fix eligible for armies
c99c382
@helloruhe
make "open spellbook" button actually open spellbook
6b00172
@helloruhe
make open spellbook button a bit bigger
8e83968
@helloruhe
Small QoL fixes
adc2937
@helloruhe
Arcane portal ritual (#1458)
7ecd9b6 
* Create portal exempt to ritual cooldown

* Create Portal Initial commit

* add gui for multiple character targets

* Add ability to select destination

* add cascading portal selection

* add empires to list first

* pan_camera_to_title when target is selected

* add tooltip for characters

* fix change destination gui clipping

* army tooltips

* fix error spam

* fix 'type' error

* fix recipient error

* remove loose variables

* add travel entourage functionality

* add tooltips to prevent people from breaking shit

* Fix army tootlip

* add tooltips/disable teleporting when army in combat

* Fix army teleportation

* Fix pt 2

* Add decision to go back home

* Remove isolated titles and titles with no barony

* fix2
@helloruhe
Merge branch 'magic-2024' into feat/code/magic-gui-overhaul
500f6d5
@helloruhe
Fix create portal
e2ac536
@helloruhe
Shadow Magic Spells (#1619)
03fdcb9 
* Add void sickness

* change voidsickness name to void touched

* Create void_sickness.dds

* spell void touch

* void touch pt2

* Summon Void Leader

* Spell: Voidborne setup

* Voidborne Events Setup

* Re-organize events

* first voidborne event

* steal pic from mariuso

* quick loc

* Rend flesh

* mutate

* Drain essence

* mania + insanity

* fix some errors

* fixes

* Silence spell

* Shadow crash

* perks names

* Ritual: Twisted chains

* Dark Ascension base + gui

* Add EPs effect

* Add ways to get evolution points

* Add EP stat tracker

* Fixes/more ways to get EP

* Event setup

* ascended events

* Fixes + Whispers setup

* Whispers event setup

* event skeletons

* add trigger loc

* Whispers: A Grim Request event

* Whispers: Enchanting Touch event

* Whispers: The Accused event

* Whispers: Heat of the Moment event

* Whispers: A Suspicious Trinket event

* Whispers: The Price of Sanity event

* Add Void Sickness to vanilla disease events and epidemic

* Whispers: The Slow Burn event

* Whispers outcome event

* change name to mind blast

* test

* UPDATE

* fix portal bug

* fixpt2

* Minor fixes

* Fix void leader wrong faith

* Fix mania tt
@helloruhe
Shadow Magic Perks (#1620)
10832b0 
* Add void sickness

* change voidsickness name to void touched

* Create void_sickness.dds

* spell void touch

* void touch pt2

* Summon Void Leader

* Spell: Voidborne setup

* Voidborne Events Setup

* Re-organize events

* first voidborne event

* steal pic from mariuso

* quick loc

* Rend flesh

* mutate

* Drain essence

* mania + insanity

* fix some errors

* fixes

* Silence spell

* Shadow crash

* perks names

* Ritual: Twisted chains

* Dark Ascension base + gui

* Add EPs effect

* Add ways to get evolution points

* Add EP stat tracker

* Fixes/more ways to get EP

* Event setup

* ascended events

* Fixes + Whispers setup

* Whispers event setup

* event skeletons

* add trigger loc

* Whispers: A Grim Request event

* Whispers: Enchanting Touch event

* Whispers: The Accused event

* Whispers: Heat of the Moment event

* Whispers: A Suspicious Trinket event

* Whispers: The Price of Sanity event

* Add Void Sickness to vanilla disease events and epidemic

* Whispers: The Slow Burn event

* Whispers outcome event

* change name to mind blast

* test

* Dark Feud

* UPDATE

* Eldritch communion

* dark bargain

* dark invasion

* dark espionage

* Misery

* hex of weakness

* Void eternal

* dark pact

* Shadow form

* void sheild

* psychic horror

* Driven to Madness

* void torrent perk

* fIx diplomacy tree

* Shadow form for laamps

* fix rend flesh

* dark invasion popup
@helloruhe
Misc/Channeled Spells (#1621)
26035a0 
* add basic spell channeling framework

* Finalize gui part

* Cancel cast on target death/title destruction

* cant channel spell twice

* power word barrier rank 2

* Dispersion

* Cancel channel when mana is gone

* Add channeled spells gui implementation

* fix df

* fix channeled spells mana values

* Fix channeled spells mana cost not being refunded correctly

* Fix channeled spels gui

* Fix power word barrier
@helloruhe
error sweep 1
40e8903
@helloruhe
fix some errors
93458b3
@helloruhe
get recipient effect
5a5cb43
@helloruhe
Init spells on game start
e8ef242
@helloruhe
CHANGE target_has_max_stacks_trigger
8af3c5d
@Grekopithikos
Merge branch 'dev' into magic-2024
b47dcfe
@Grekopithikos
Update 60000_63000_lordaeronian.txt
307a3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helloruhe helloruhe helloruhe left review comments

@robmart robmart robmart left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@robmart robmart

@edmund-h edmund-h

@helloruhe helloruhe

Labels
new feature ⭐ Involves adding new feature that affects game
Projects
None yet
Milestone
No milestone
7 participants
@sumankun @robmart @helloruhe @edmund-h @Grekopithikos @MemeWizard @Myphicbowser