Pre-extract the boxed plugin bundle #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses two issues: * Improves boxed plugin startup time. * Lessens chance of free disk space errors, such as "Consider setting TMPDIR to a directory with more free space". This is part of the longer-term effort to support distributions based on Musl libc (such as Alpine) by moving the glibc-based bundle into it's own directory. The bundle build process is now its own Dockerfile so we can re-use it (via docker-bake.hcl) to build both Glibc and Musl variants.
ZoogieZork
force-pushed
the
zoogiezork/extract-box
branch
from
4fb34e5 to
562de29
Compare
Fixes engine startup issue where it was trying to auto-register the directory as a plugin.
Kamsiy
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses two issues:
This is part of the longer-term effort to support distributions based on Musl libc (such as Alpine) by moving the glibc-based bundle into it's own directory. The bundle build process is now its own Dockerfile so we can re-use it (via docker-bake.hcl) to build both Glibc and Musl variants.
Motivation and Context
Extracting the plugin bundle into each container added to the startup time of each boxed plugin and required an additional 400+ MB of free space.
How Has This Been Tested?
TODO
Types of changes
Checklist