-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Veracode dependencies and python3 base image #65
Conversation
@@ -1,4 +1,4 @@ | |||
FROM python:3-alpine | |||
FROM python:3.11-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some mechanism to come back to this?
If we don't have something outside the repo, maybe we can comment the reason that's in the description. Someone in the future might not look at this PR and, just looking at the code, the reason it's pinned to 3.11
is not obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, I'll add a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Veracode Dockerfile:
major.minor
versions, rather than specific SHAs, to accept patch-level updateshttps://repo.maven.apache.org
, which keeps previous versions available (unlikehttps://downloads.apache.org
)python3 Dockerfile:
python3.11
, rather than major versionpython3
Motivation and Context
Veracode image
The Veracode container image was failing to build because some of its highly specific package versions were no longer available to
apt-get
, and because its specified version of Maven was no longer available athttps://downloads.apache.org
. This PR undoes some of the work from #62 in the interest of automatically accepting patch-level updates, reducing the frequency of required image maintenance.python3 image
When the
python3
image shifted to Python 3.12, the image would no longer build due to: aio-libs/aiohttp#7739How Has This Been Tested?
Types of changes
Checklist
Pic