Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have SBOM errors/alerts/debug bubble up to scan result #77

Merged
merged 21 commits into from
Nov 20, 2023

Conversation

g-marconet
Copy link
Contributor

With this change, SBOM errors/alerts/debugs will bubble up to the scan result.

Description

  • SBOM errors/alerts/debugs were going unreported as SBOM results are delivered via S3 rather than through the database like other plugin results. This PR allows SBOM errors/alerts/debugs and SBOM status to be returned in the normal scan result.
  • Adds an 8hr timeout to veracode_sbom

Motivation and Context

  • We wanted to add a timeout to veracode_sbom, as we had run into issues with some scans looping infinitely.
  • With a timeout and prior to this PR, we would get no feedback about the SBOM scan timing out.
  • Now, a notification about the timeout will be visible in the API results and in the Artemis web UI.

How Has This Been Tested?

  • Tests pass
  • Working locally
  • Working in nonprod

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@g-marconet g-marconet requested a review from a team as a code owner November 15, 2023 23:02
@g-marconet g-marconet marked this pull request as draft November 15, 2023 23:34
@g-marconet g-marconet marked this pull request as ready for review November 15, 2023 23:49
@g-marconet g-marconet merged commit 1ea3c7b into main Nov 20, 2023
1 check passed
@g-marconet g-marconet deleted the g-marconet/sbom-errors branch November 20, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants