Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gosec to version 2.18.2 #85

Merged
merged 1 commit into from
Jan 23, 2024
Merged

update gosec to version 2.18.2 #85

merged 1 commit into from
Jan 23, 2024

Conversation

Kamsiy
Copy link
Contributor

@Kamsiy Kamsiy commented Jan 23, 2024 •
edited
Loading

Description

Updated the gosec version in Artemis from 2.6.1 to 2.18.2

Motivation and Context

Gosec hasn't been updated on Artemis in a while. This changes updates gosec to the most recent version

How Has This Been Tested?

  • Ran both versions of gosec on a test repo and compared the results side by side.
  • Pushed to a dev environment and smoke tested
  • Built locally without any errors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Kamsiy Kamsiy marked this pull request as ready for review January 23, 2024 19:20
@Kamsiy Kamsiy requested a review from a team as a code owner January 23, 2024 19:20
faizanH
faizanH approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@faizanH faizanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kamsiy Kamsiy merged commit 79e11bb into main Jan 23, 2024
2 checks passed
@Kamsiy Kamsiy deleted the update-gosec branch January 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faizanH faizanH faizanH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kamsiy @faizanH