fix(config): Add missing environment variable for devOptions.skipUpdateCheck parameter #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmedlar
force-pushed
the
wm/skip-update-check
branch
2 times, most recently
from
7320e43 to
63b0297
Compare
TurtIeSocks
requested changes
Jun 19, 2024
server/src/index.js
Outdated
| const skipUpdateCheck = config.has('devOptions.skipUpdateCheck') | ||
| ? config.getSafe('devOptions.skipUpdateCheck') | ||
| : false | ||
| if (!skipUpdateCheck) { |
There was a problem hiding this comment.
Suggested change
| if (!skipUpdateCheck) { | |
| if (!config.getSafe('devOptions.skipUpdateCheck')) { |
The only reason the has is being called was because this value often didn't exist in the config. Now that it's in default.json, you don't need it and you can just check the value right in the if statement.
There was a problem hiding this comment.
Updated, rebased, and retargeted to develop 👍
…teCheck parameter
wmedlar
force-pushed
the
wm/skip-update-check
branch
from
63b0297 to
14eca4c
Compare
TurtIeSocks
approved these changes
Jun 21, 2024
|
🎉 This PR is included in version 1.33.0-develop.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a missing environment variable for the
devOptions.skipUpdateCheckboolean parameter —DEV_OPTIONS_SKIP_UPDATE_CHECK. This option defaults to false, running the update check at boot.Skipping the update check marginally reduces boot time and prevents a warning message when
gitis not installed (such as in a minimal container image).Below is a brief demonstration of the change on a system that does have git installed:
DEV_OPTIONS_SKIP_UPDATE_CHECKnot setDEV_OPTIONS_SKIP_UPDATE_CHECKset to trueDEV_OPTIONS_SKIP_UPDATE_CHECKset to falsedevOptions.skipUpdateCheckis not present in the server config file.