feat: german translations for dynamax #1054
Conversation
packages/locales/lib/human/de.json
Outdated
| "dynamax": "Dynamax", | ||
| "stations_subtitle": "Kraftquellen auf der Map anzeigen", | ||
| "dynamax_subtitle": "Dyna-Raids auf der Map anzeigen", | ||
| "override": "Dyna-Raid Override" |
There was a problem hiding this comment.
is this "override" just used for Dyna-Raid or for every other preset-filter like raids?
There was a problem hiding this comment.
@TurtIeSocks did you publish this key on purpose like that? instead dyna_override like for raid_override ? :)
packages/locales/lib/human/de.json
Outdated
| "stations": "Dynamax", | ||
| "stations_options": "Kraftquellen Optionen", | ||
| "all_stations": "alle Kraftquellen", | ||
| "search_battles": "Suche Dyna-Raids", |
There was a problem hiding this comment.
Why not being consistent with search phrases? :)
There was a problem hiding this comment.
It's the same in English. Stations/Battles used in backend, translated to Power Spots/Dynamax or Max Battles in clients.
There was a problem hiding this comment.
@TurtIeSocks was more about the translation itself, he changed the other search_key values, but this matches the old phrasing :)
it's not about dyna/spots or something else :)
There was a problem hiding this comment.
I left it generic in this case. In English it's just Override without any category attached to it. Dynamax or Max Battles as a prefix was just too long and feels unnecessary with the way the UI is setup.
packages/locales/lib/human/de.json
Outdated
| "unknown_station": "unbekannte Kraftquelle", | ||
| "exclude_battle": "Dyna-Raids ausschließen", | ||
| "station": "Kraftquelle", | ||
| "stations": "Dynamax", |
There was a problem hiding this comment.
Singular = Kraftquelle
plural = Dynamax ?
I think this should be "Kraftquellen"
this? |
packages/locales/lib/human/de.json
Outdated
| "stations_filters": "Dynamax Filter Einstellungen", | ||
| "stations_options": "Kraftquellen Optionen", | ||
| "all_stations": "alle Kraftquellen", | ||
| "search_battles": "Suche Dyna-Raids", |
There was a problem hiding this comment.
| "search_battles": "Suche Dyna-Raids", | |
| "search_battles": "Dyna-Raids durchsuchen", |
packages/locales/lib/human/de.json
Outdated
| "search_raids": "Raids durchsuchen", | ||
| "search_eggs": "Eier durchsuchen", | ||
| "search_quests": "Quests durchsuchen", | ||
| "search_lures": "Lockmodulen durchsuchen", |
There was a problem hiding this comment.
| "search_lures": "Lockmodulen durchsuchen", | |
| "search_lures": "Lockmodule durchsuchen", |
|
One more comment.. but I think you need to rebase on latest and maybe drop zhe commits of the tsx file which have been reverted first... Guess those are causing the conflict |
TurtIeSocks
force-pushed
the
dynamax
branch
from
cdaca12 to
826ef80
Compare
|
🎉 This PR is included in version 1.35.0-develop.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.