Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: large refactoring of filtering functionality and performance #909

Merged
merged 50 commits into from
Jan 10, 2024

Conversation

TurtIeSocks
Copy link
Collaborator

This is a huge refactor of some truly awful code that I wrote years ago.

  • useDeepStore for vast improvements to how state is received and set
  • useTranslateById hook for a central place to translate RM's various object keys
  • Much improved component memoizing and zustand usage to improve rendering performance
  • Huge cleanup of the advanced filters (where you set individual filters for pokemon) menu
  • Adds a lot more typings to the stores for better dev experience
  • Simplifies a lot of overly complex components
  • Based on feat: quick filters (and a filtering refactor) #907

@TurtIeSocks TurtIeSocks marked this pull request as ready for review January 10, 2024 00:44
@TurtIeSocks TurtIeSocks merged commit 967a98d into quick-pkmn-filters Jan 10, 2024
3 checks passed
@TurtIeSocks TurtIeSocks deleted the filter-code-refactoring branch January 10, 2024 00:49
Copy link

🎉 This PR is included in version 1.28.0-develop.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.29.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant