Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move distance unit to client #966

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Conversation

TurtIeSocks
Copy link
Collaborator

Moves the distance selection to the client for more consistency and there's not really any reason why this calculation should be forced to be the same for all users.

Config Change

map.misc.distanceUnit was previously km/mi and is now kilometers/miles, an inline migration was added to change it at startup with a warning log.

Resolves #865

@TurtIeSocks TurtIeSocks merged commit 2c1ce16 into develop Feb 24, 2024
2 checks passed
@TurtIeSocks TurtIeSocks deleted the client-distance-unit branch February 24, 2024 00:18
@kamieniarz
Copy link
Contributor

@TurtIeSocks kilometers and miles translations don't work

Copy link

🎉 This PR is included in version 1.30.0-develop.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants