fix: add new i18n keys, data management page and Update de.json #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, good catches. Thanks! Awaiting your review, @Fabio1988 |
Fabio1988
reviewed
Feb 28, 2024
packages/locales/lib/human/de.json
Outdated
| "filter_help": "Filter Hilfe" | ||
| "filter_help": "Filter Hilfe", | ||
| "kilometers": "Kilometer", | ||
| "miles": "Miles", |
Fabio1988
reviewed
Feb 28, 2024
packages/locales/lib/human/de.json
Outdated
| "filter_help": "Filter Hilfe", | ||
| "kilometers": "Kilometer", | ||
| "miles": "Miles", | ||
| "distance_unit": "Entfernungseinheit", |
Fabio1988
reviewed
Feb 28, 2024
| "kilometers": "Kilometer", | ||
| "miles": "Miles", | ||
| "distance_unit": "Entfernungseinheit", | ||
| "data_management": "Einstellungsverwaltung", |
There was a problem hiding this comment.
Datenverwaltung
Or do you think it's more intuitive to name it like you said?
Fabio1988
reviewed
Feb 28, 2024
packages/locales/lib/human/de.json
Outdated
| "reset_general": "Allgemein", | ||
| "reset_assets": "Styles", | ||
| "reset_filters": "Filter", | ||
| "reset_pokemon": "Pokémons zurücksetzen", |
There was a problem hiding this comment.
There is no "Pokémons", only plural "Pokémon"
|
think the translation is fine now @TurtIeSocks |
Fabio1988
approved these changes
Mar 2, 2024
|
🎉 This PR is included in version 1.30.0-develop.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.