Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.8 compatibility #20

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add Python 3.8 compatibility #20

merged 1 commit into from
Jun 4, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented May 31, 2024

Description

This PR adds compatibility for coSMicQC with Python 3.8. To do this, I had to use custom markers as the latest versions of Scipy and Pandas are no longer compatible with Python 3.8. While I was doing this work, I also updated other existing dependencies (which will show in the lockfile).

Thanks for any feedback you may have!

Closes #18
References #19

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 We will keep the plan to remove after it is "expired".

@d33bs
Copy link
Member Author

d33bs commented Jun 4, 2024

Thanks @jenna-tomkinson ! Agreed - we'll follow up sometime near October 2024 to update the project for 3.8 end-of-life via #19 .

@d33bs d33bs merged commit 74870df into WayScience:main Jun 4, 2024
11 checks passed
@d33bs d33bs deleted the python-3.8 branch June 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Python 3.8 compatibility
2 participants