Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Itemid load condition #4653

Closed
Talimar opened this issue Oct 14, 2023 · 1 comment
Closed

Itemid load condition #4653

Talimar opened this issue Oct 14, 2023 · 1 comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@Talimar
Copy link

Talimar commented Oct 14, 2023

At the bottom of load conditions there is "!not item bonus id equipped".
It threw me off at first, but you can use this to hide auras with regular itemid as well.
So I am asking to just improve the description to not only include bonusid.
@Talimar Talimar added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Oct 14, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Oct 14, 2023
@InfusOnWoW
Copy link
Contributor

That would be a bug then. It's not supposed to check the itemId.

InfusOnWoW added a commit to InfusOnWoW/WeakAuras2 that referenced this issue Oct 15, 2023
@InfusOnWoW
Fix Bonus Id load options to not consier item ids bonus ids
b350cf4 
Fixes: WeakAuras#4653
@Wraiyth1 Wraiyth1 mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@InfusOnWoW @Talimar