Smallpatches #4608
Merged
Smallpatches #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbuds
requested changes
Sep 17, 2023
Noteable blizzard only sends those events if there's a RegisterUnitEvent that for a specific unit. They probably are optimizing the checking to only Register the event if a buff trigger is loaded that requires it. Also we dance a bit to ensure that we don't register for pets unless necessary. Fixes: WeakAuras#4542
Use WA_DELAYED_PLAYER_ENTERING_WORLD because PEW apparently doesn't work. Fixes: WeakAuras#4603
0 is "RemoteTransmission", I think we want 1 "LocalPlayback". Might help with WeakAuras#4605
If the voiceId is not valid, don't hardcode the fallback to 0, because that might not be a valid voiceId, instead fallback to the "first" voiceId
Due to how the multi-selection works we need to always create the dummy spacer item and the real controls and hide the ones that we don't need. But the default hiddenAll doesn't work for the dummy widget, as we only want it to show if the input widget is hidden, thus add another hack to our options code. Nothing bad can come from that. Fixes: WeakAuras#4604
InfusOnWoW
force-pushed
the
smallpatches
branch
from
e1b166b to
89800d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.