fix #4662
Merged
fix #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce issue before this change, install Prat-3.0, set an aura with text or subtext using font DorisPP, and text should not show, it will work after a /reload but will break if you restart wow client
…on take multiple inputs fixes WeakAuras#4663
… names option is toggle
|
I can't reproduce the font issue, the font and also another shipped with prat just work correctly. Probably has something to do with how fast the fonts can be loaded. |
InfusOnWoW
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use font loading workaround use by https://www.curseforge.com/wow/addons/libddi-1-0
I'm not 100% sure it's correct to use same objectName with potentially different settings for same font, but it would be bad to create too much of these objects