Smallpatches #4671
Merged
Smallpatches #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the current behaviour of searching for the name of the spell and then showing all icons that match the name. I don't think anyone will miss that behaviour. Fixes: WeakAuras#4667
Apparently this is broken on retail. Fixes: WeakAuras#4666
Outside a group, UnitInRange("player") returns false, false, which means
that no check was done on whether the player was in range.
So we wrap UnitInRange in a small function which treats the non-checking
case as in range.
Fixes: WeakAuras#4670
mrbuds
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.