advertise a link to an experimental build, if one exists #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emptyrivers
added
the
✨Housekeeping
emptyrivers
force-pushed
the
advertise_previews
branch
from
b940243 to
ccfa79e
Compare
emptyrivers
commented
Apr 29, 2024
| on: [pull_request] | ||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, labeled] |
There was a problem hiding this comment.
slight weirdness here: a build is retriggered if someone edits the labels. I wanted to keep this to just 'feature preview' prs, so there's some discernment about which changes we actually expect someone to install & give feedback on. But we could also ditch that if frivolous retriggers are considered annoying
Stanzilla
reviewed
Apr 29, 2024
.github/workflows/pull_request.yml
Outdated
| with: | ||
| name: WeakAuras-PR#${{ github.event.number }}-${{ github.sha }} | ||
| path: .release/ | ||
|
|
||
| - name: test |
There was a problem hiding this comment.
what does this do exactly?
There was a problem hiding this comment.
anything you want, so long as that isn't very useful
There was a problem hiding this comment.
It obviously tests duh
emptyrivers
force-pushed
the
advertise_previews
branch
from
ccfa79e to
e9b4c9f
Compare
|
What if this posted to #wow-addon and pings @WAalpha |
InfusOnWoW
reviewed
Apr 30, 2024
InfusOnWoW
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try opening a pull request (any kind!) over on my fork, or see emptyrivers#12 for an example.
Will only post links for pull requests with the feature preview label.