Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEditor: add "Search API" side panel #5170

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mrbuds
Copy link
Contributor

@mrbuds mrbuds commented Jun 19, 2024

This is a lighter version of #4983 without the features i'm not happy with (for the reasons told in this comment)

This does not include WeakAuras's API automatically generated + added to game's api documentation
This does not include a "intellisense" widget

- require 4 characters instead of 3 to make a full search
- remember last search to not redo last search or list of systems (save cpu when typing first characters)
- still search functions & events in all systems when search match a namespace's name
Copy link
Contributor

@InfusOnWoW InfusOnWoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good enough for me. I'm not 100% sure of the right algorithm either, but that can be tweaked later anyway.

@InfusOnWoW InfusOnWoW merged commit 81e4086 into WeakAuras:main Jun 20, 2024
3 checks passed
@mrbuds mrbuds mentioned this pull request Jul 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants