Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for translatable/readonly for uploaded/downloaded Android Resource Format #12697

Conversation

harriebird
Copy link
Contributor

@harriebird harriebird commented Oct 6, 2024

Proposed changes

This adds readonly/translatable support for Android Resource format. Prior to this change, the translatable tag in the uploaded Android Resource file is ignored in the web UI and it is not added when downloading the file. With this, translatable="false" adds a readonly state. The said tag is kept even in the downloaded file. The dependency translate-toolkit minimum version was set to 3.13.4 to utilize those changes related to this.
This solves issue #4902.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@harriebird harriebird marked this pull request as ready for review October 6, 2024 19:43
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (cb14410) to head (118fd7c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12697      +/-   ##
==========================================
- Coverage   91.19%   91.15%   -0.04%     
==========================================
  Files         596      596              
  Lines       61071    61091      +20     
  Branches     6340     6341       +1     
==========================================
- Hits        55695    55690       -5     
- Misses       3728     3753      +25     
  Partials     1648     1648              
Files with missing lines Coverage Δ
weblate/formats/ttkit.py 91.45% <100.00%> (+0.03%) ⬆️
weblate/trans/models/translation.py 86.10% <ø> (ø)
weblate/trans/tests/test_files.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@harriebird harriebird force-pushed the feature/add-readonly-support-in-android-resource-format branch from 55d7d03 to 66c01d8 Compare October 7, 2024 15:15
@harriebird harriebird changed the title Added support for translatable/readonly for uploaded/downloaded Android Resource Format Add support for translatable/readonly for uploaded/downloaded Android Resource Format Oct 8, 2024
@nijel nijel added this to the 5.8 milestone Oct 11, 2024
@nijel nijel self-assigned this Oct 11, 2024
@nijel nijel enabled auto-merge (squash) October 11, 2024 11:41
@nijel nijel merged commit 5e11486 into WeblateOrg:main Oct 11, 2024
33 of 35 checks passed
@nijel nijel linked an issue Oct 14, 2024 that may be closed by this pull request
@harriebird harriebird deleted the feature/add-readonly-support-in-android-resource-format branch November 7, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for read only state in exporters
2 participants