Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tributejs to new workflow #12731

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Move tributejs to new workflow #12731

merged 2 commits into from
Oct 11, 2024

Conversation

meel-hd
Copy link
Contributor

@meel-hd meel-hd commented Oct 10, 2024

Proposed changes

  • Removed tribute from the old workflow to the new one in client/
  • Built the libarary into static/js/vendor/tribute.js then
  • Used by the base.html template
  • Added license files and info using webpack during build
  • Improved the mainLicenseTransform function for better multiple library licenses exclusion handling.
  • Updated and added documentation for client 3rd party licenses management

Related: #12172

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@meel-hd
Add tributejs library to be managed by client/
cf9aea2 
- Removed tribute from the old workflow to the new one in client/
- Built the libarary into static/js/vendor/tribute.js then
- Used by the base.html template
- Added license files and info using webpack during build
- Improved the mainLicenseTransform function for better multiple library liceses exclusion handling.
@meel-hd
Document client 3rd party licenses management
f95e028
@meel-hd meel-hd requested a review from orangesunny as a code owner October 10, 2024 13:03
@meel-hd meel-hd requested review from nijel and removed request for orangesunny October 10, 2024 13:03
@meel-hd meel-hd mentioned this pull request Oct 10, 2024
Closed
11 tasks
@nijel nijel merged commit dcbe5cb into WeblateOrg:main Oct 11, 2024
33 of 35 checks passed
@nijel nijel added this to the 5.8 milestone Oct 11, 2024
@nijel nijel self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijel nijel Awaiting requested review from nijel

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
2 participants
@meel-hd @nijel