Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): correct repository full_name extraction #13410

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ron31
Copy link

@Ron31 Ron31 commented Dec 30, 2024

Proposed changes

Replaces manual parsing of the SSH URL with the provided path_with_namespace from the GitLab payload. This ensures accurate retrieval of the repository's full name.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

See https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html for example payloads from GitLab

Replaces manual parsing of the SSH URL with the provided `path_with_namespace` from the GitLab payload. This ensures accurate retrieval of the repository's full name and avoids potential parsing errors.
@Ron31 Ron31 force-pushed the gitlab-project-fullname branch from 0a8d37f to 02664bb Compare December 31, 2024 00:04
Ron31 added 2 commits January 1, 2025 13:45
Replaces manual parsing of the SSH URL with the provided `path_with_namespace` from the GitLab payload. This ensures accurate retrieval of the repository's full name and avoids potential parsing errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant