Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add events to calendar #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fid-jose
Copy link

This commit adds a new button which adds the current event to the calendar

@Wilm0r
Copy link
Owner

Wilm0r commented Jan 12, 2017

Sorry for the long delay. :-( Finally figured out how to easily test a PR locally without having to create a separate project in Android Studio. Few things:

For consistency and space reasons, I'd definitely want this to be an icon, not a text button. Though I can't really find a super suitable one among either Android Drawables or the Material Design icon set.. :-/ But maybe one of the icons when you search https://material.io/icons/ for the word "event"?

And what kinda sucks in Giggity and will bite especially here: Timezone awareness. When I wrote Giggity, I think the Pentabarf format didn't have TZ info yet, so I just parse everything as if it were local, and flush all the parsed data on timezone changes so that a reload will happen.

But if calendar events get created, they will be for the wrong time if the user is not yet in the timezone of the event... I'd rather not add this feature yet as long as it'd be so sensitive to this bug, what do you think?

@Wilm0r
Copy link
Owner

Wilm0r commented Jan 15, 2017

OK, I may have a plan for making Giggity timezone-aware, now I just need some time to try it out..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants