TabPanel: Add 40px size prop to tab Button #66557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
commented
Oct 29, 2024
Comment on lines
-10
to
-11
| // This tab style CSS is duplicated verbatim in | ||
| // /packages/edit-post/src/components/sidebar/settings-header/style.scss |
There was a problem hiding this comment.
This stylesheet was completely removed in #55360.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 29, 2024
| @@ -220,6 +220,7 @@ const UnforwardedTabPanel = ( | |||
| ) }-view` } | |||
| render={ | |||
| <Button | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
It's a bit of a bummer that this prop is a no-op here due to the style override.
| .components-tab-panel__tabs-item { | ||
| position: relative; | ||
| border-radius: 0; | ||
| height: $grid-unit-60; | ||
| height: $grid-unit-60 !important; // https://github.com/WordPress/gutenberg/pull/65075#discussion_r1746282734 |
There was a problem hiding this comment.
👍 I'd love it if we can clean those up at some point.
There was a problem hiding this comment.
It should be pretty simple to sweep up after the 40px becomes the default.
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* TabPanel: Add 40px size prop to tab Button * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #65751
What?
Adds
__next40pxDefaultSizeprop to the Button in TabPanel.Testing Instructions
See the TabPanel story in Storybook. There should be no visual changes.