Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: Add 40px size prop to Button #66589

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Panel: Add 40px size prop to Button #66589

merged 3 commits into from
Oct 30, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Oct 30, 2024

In preparation for #65751

What?

Adds __next40pxDefaultSize prop to the Button in the Panel component.

Testing Instructions

See the Panel story in Storybook. There should be no visual changes.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 30, 2024
@mirka mirka self-assigned this Oct 30, 2024
@mirka mirka requested a review from ajitbohra as a code owner October 30, 2024 11:06
Copy link

github-actions bot commented Oct 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team October 30, 2024 11:07
Copy link

github-actions bot commented Oct 30, 2024

Flaky tests detected in 89847b6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11592952135
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panel title button is unchanged 👍 🚀

@mirka mirka merged commit d4c153a into trunk Oct 30, 2024
64 checks passed
@mirka mirka deleted the panel-button-40px branch October 30, 2024 14:33
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Oct 30, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
* Panel: Add 40px size prop to Button

* Add changelog

* Update snapshot

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants