-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl : Deprecate 36px default size #66747
Changes from 4 commits
8e57f51
64b9992
64c8fb0
1b7eeec
d1337d9
fd348c0
0dca97d
fdad7a6
e3d0c99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ const FontSizePickerToggleGroup = ( props: FontSizePickerToggleGroupProps ) => { | |
<ToggleGroupControl | ||
__nextHasNoMarginBottom | ||
__next40pxDefaultSize={ __next40pxDefaultSize } | ||
__shouldNotWarnDeprecated36pxSize | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we're also going to need a prop like this to prevent the redundant warnings when used inside another component: 1b7eeec There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @mirka should we also update the usage of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not that I'm aware of. We only want to suppress the warning when ToggleGroupControl's size is dependent on a parent component's size, and the parent component is responsible for logging the warning. I'm not aware of any other cases like that. |
||
label={ __( 'Font size' ) } | ||
hideLabelFromVision | ||
value={ value } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this up to the Unreleased section.