Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectControl : Deprecate 36px default size #66898

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

PARTHVATALIYA
Copy link
Contributor

Part of #65751

What?

Deprecate the 36px default size in SelectControl.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled

Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @parthVataliya16.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: parthVataliya16.

Co-authored-by: PARTHVATALIYA <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@PARTHVATALIYA PARTHVATALIYA changed the title Add the changelog for the deprecation SelectControl : Deprecate 36px default size Nov 11, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things:

  • In addition to this, there are a lot of code snippets in Markdown files across the repo that use SelectControl, and all of them need the prop. Otherwise the devs referring to those snippets would be copy pasting deprecated code. (I added some clarification in the original issue's procedure checklist.)
  • We should also add the prop to the SelectControl usage in the Storybook story for the Disabled component.
  • In a previous PR I introduced a way to suppress warnings when the component's size is dependent on a parent component's size, and the parent component is responsible for logging the warning. I went ahead and added (70b6769) that to the relevant components here, which are DimensionControl and TreeSelect.

packages/components/src/select-control/index.tsx Outdated Show resolved Hide resolved
packages/components/src/select-control/index.tsx Outdated Show resolved Hide resolved
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Needs Dev Note Requires a developer note for a major WordPress release cycle labels Nov 20, 2024
@mirka
Copy link
Member

mirka commented Dec 2, 2024

@PARTHVATALIYA Hi 👋 I need these merged soon, are you still available or do you need someone to take over? 🙂

@PARTHVATALIYA
Copy link
Contributor Author

Hello @mirka, Sorry for the inconvenience! I wasn’t able to resolve the deprecation warning. Could you please guide me, or feel free to take over if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants