Storybook: Support keyword search in Icon Library #67442
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
mirka
commented
Nov 29, 2024
| ) | ||
| : availableIcons; | ||
| return ( | ||
| <div style={ { padding: 20 } }> | ||
| <label htmlFor="filter-icon" style={ { paddingRight: 10 } }> | ||
| <label htmlFor="filter-icons" style={ { paddingRight: 10 } }> |
There was a problem hiding this comment.
Small accessibility error here.
Comment on lines
+2
to
+10
| cancelCircleFilled: [ 'close' ], | ||
| create: [ 'add' ], | ||
| file: [ 'folder' ], | ||
| seen: [ 'show' ], | ||
| thumbsDown: [ 'dislike' ], | ||
| thumbsUp: [ 'like' ], | ||
| trash: [ 'delete' ], | ||
| unseen: [ 'hide' ], | ||
| warning: [ 'alert', 'caution' ], |
There was a problem hiding this comment.
@WordPress/gutenberg-design I assume there will also be some keywords we don't want to add, to discourage people misusing icons for certain things? I added some obvious keywords to start, but let me know if there's something that should be removed. (Maybe we could document those no-nos.)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Support keyword search for the Icon Library in Storybook.
Why?
I was looking at some new icons being added in #61106 (comment) and thought we're at the point where keyword searching could be useful.
How?
Not sure if we'll eventually want to use this metadata elsewhere, but for now I added a separate file with keywords for certain icons.
Testing Instructions
See the Storybook story for Icons ▸ Library.
Screenshots or screencast