Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch PHP 8.3 to stable #126

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Switch PHP 8.3 to stable #126

merged 1 commit into from
Dec 7, 2023

Conversation

johnbillion
Copy link
Member

No description provided.

@johnbillion johnbillion requested review from desrosj and jrfnl November 28, 2023 15:35
@johnbillion johnbillion changed the title Switch to PHP 8.3 stable Switch PHP 8.3 to stable Nov 28, 2023
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I went to make this change late last week, but docker-library/php had not yet been updated.

Any reason why we shouldn't also update $latest to be 8.3 at the same time?

I was hoping we could add the PECL extensions in there now as well. imagick and memcached have not yet been updated, and xDebug has 3.3.0alpha2 out which adds support for PHP 8.3. So just need to follow up a bit later for those.

@johnbillion
Copy link
Member Author

I noticed memcached wasn't available and caused the container to fail to start when trying to run it with LOCAL_PHP_MEMCACHED in the core repo.

I didn't bump the latest as this was done separately for 8.2: #60

@desrosj
Copy link
Contributor

desrosj commented Nov 28, 2023

I'm fine with separately. The main reason why that was separate was due to 8.0 and 8.1 never being set to latest. I wouldn't mind establishing the practice of bumping latest at the same time as GA for a new version, but it may best to evaluate any side effects each time.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went to make this change late last week, but docker-library/php had not yet been updated.

Dito ;-) Still have the Docker page open in a tab waiting for it to be available. Thanks @johnbillion for spotting it!

@jrfnl
Copy link
Member

jrfnl commented Nov 28, 2023

I'm fine with separately. The main reason why that was separate was due to 8.0 and 8.1 never being set to latest. I wouldn't mind establishing the practice of bumping latest at the same time as GA for a new version, but it may best to evaluate any side effects each time.

I'd say: let's make it latest once the extensions are available.

Note: at this time, the WP Core xdebug test group is still not being run on PHP 8.3 due to there not being a stable version supporting 8.3 available. Along the same lines, I expect a number of imagick tests are currently being skipped.

@jrfnl
Copy link
Member

jrfnl commented Nov 30, 2023

FYI: Xdebug 3.3.0 has been released: https://xdebug.org/announcements/2023-11-30

@jrfnl
Copy link
Member

jrfnl commented Dec 6, 2023

Just saw this - Imagick is not (yet) PHP 8.3 compatible: Imagick/imagick#641

@johnbillion johnbillion merged commit 01017bd into trunk Dec 7, 2023
50 checks passed
@johnbillion johnbillion deleted the 83-stable branch December 7, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants