Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'git' apt dependency to php Dockerfile #23

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

noisysocks
Copy link
Member

Adds git to the php images that have composer installed. git is required by composer in some circumstances, for example when running composer install --prefer-source.

By doing this, I'm aiming to fix the issue described in WordPress/gutenberg#21118 (comment).

Adds git to the php images that have composer installed. git is required
by composer in some circumstances, for example when running `composer
install --prefer-source`.
@noisysocks
Copy link
Member Author

I tested this in my local wordpress-develop by:

  1. Setting php.image in docker-compose.yml to:

    image: docker.pkg.github.com/wordpress/wpdev-docker-images/php:${LOCAL_PHP-latest}-23
  2. npm run env:start

  3. npm run env:install

  4. docker-compose run php composer install --prefer-source

I then confirmed that http://localhost:888/wp-admin/ still loaded and that vendor had been created by composer.

Copy link

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, git it done.

@pento
Copy link
Member

pento commented Mar 25, 2020

cc @getsource, since we discussed this in #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants