Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nikos Kostoulas <[email protected]>
  • Loading branch information
kalyvasio and nikostoulas committed Jul 10, 2024
1 parent 3b9ec03 commit 5da9d39
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,4 @@ ObjectId using new mongoose.
- Changes in default config: istioTraceHeaders and headerPropagation are deprecated in favor of a generic propagatedHeaders
- Methods kafka.send that was deprecated is removed. Use kafka.producer.send instead
- Mongoose migrated to v7 which has breaking changes see [here](https://mongoosejs.com/docs/7.x/docs/migrating_to_7.html)

### Migrating from orka 4.x to 5.x
- KafkaJS version is specified to 2.x.x. KafkaJS 2.x.x will use the JavaCompatiblePartitioner as the DefaultPartitioner
- Additional information about breaking changes when migrating to KafkaJS 2.x.x can be found at https://kafka.js.org/docs/migration-guide-v2.0.0#producer-new-default-partitioner
- If needed, you can specify the old Default Partitioner by passing it as an option when instantiating Orka (more info [here](https://workable.github.io/orka/integrations/kafka.html#migrating-from-orka--5xx))
- KafkaJS version is specified to 2.x.x. Additional information about breaking changes when migrating to KafkaJS 2.x.x can be found at https://kafka.js.org/docs/migration-guide-v2.0.0
4 changes: 2 additions & 2 deletions docs/integrations/kafka.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,15 +243,15 @@ Once the new group ids are created you can remove the code that copies their off

If you are using the renameGroupIds (before creating your consumers) your consumers will continue reading messages from the offset specified from the old groupId regardless if you set the fromBeginning configuration. FromBeginning configuration will be used if the groupId, topic is not found in kafka.

## Migrating from orka < 5.x.x
## Migrating from orka < 4.x.x

Since Orka 5.x.x, the required KafkaJS version is ^2.x.x
(more info on the KafkaJS changes [here](https://kafka.js.org/docs/migration-guide-v2.0.0))

The only possible implication is the update of the DefaultPartitioner (https://kafka.js.org/docs/migration-guide-v2.0.0#producer-new-default-partitioner). This may case
issues in partition-aware environments, since some messages may be produced in different partitions than they would with the previous default partitioner.

By default, Orka ^5.x.x will use the new DefaultPartitioner (previously named JavaCompatiblePartitioner).
By default, Orka ^4.x.x will use the new DefaultPartitioner (previously named JavaCompatiblePartitioner).
You can use the previous DefaultPartitioner (now renamed to LegacyPartitioner) with:

```js
Expand Down

0 comments on commit 5da9d39

Please sign in to comment.