[PROD-34066] Upgrades mongoose to version 7 and removes mongodb dependency #358
Conversation
iliasbibas
force-pushed
the
change/PROD-34066-upgrade-mongo-7
branch
from
4032814 to
fd12cdc
Compare
iliasbibas
requested review from
jgerbe,
klesgidis,
kzacharakis,
nikosd23,
nikostoulas,
stavros-wb and
manoskouvarakis
as code owners
package.json
Outdated
| @@ -66,7 +66,8 @@ | |||
| "koa2-cors": "^2.0.6", | |||
| "lodash": "^4.17.15", | |||
| "log4js": "^6.7.1", | |||
| "mongoose": "6.*", | |||
| "mongodb": "~5.9.1", | |||
There was a problem hiding this comment.
❓ why so strict? why not "^5.9.1"
There was a problem hiding this comment.
I see in the compatibility table of mongo that they change support (upwards) using minor versions for the driver, so I opted to keep the minor version constant for orka as well. I changed it to ^ to be less restrictive.
package.json
Outdated
| @@ -66,7 +66,8 @@ | |||
| "koa2-cors": "^2.0.6", | |||
| "lodash": "^4.17.15", | |||
| "log4js": "^6.7.1", | |||
| "mongoose": "6.*", | |||
| "mongodb": "~5.9.1", | |||
| "mongoose": "^7.6.7", | |||
There was a problem hiding this comment.
❓ since orka is in 4.0 beta, do we want to make it only mongo7 compatible? @nikostoulas WDYT?
There was a problem hiding this comment.
Sure! Let's use 7.* to not restrict apps from getting latest updates
There was a problem hiding this comment.
👍 I'll use the 7.* notation for clarity
iliasbibas
force-pushed
the
change/PROD-34066-upgrade-mongo-7
branch
from
fd12cdc to
c36fc05
Compare
|
@iliasbibas have you tried removing the dependency to mongodb altogether? |
|
iliasbibas
force-pushed
the
change/PROD-34066-upgrade-mongo-7
branch
from
c36fc05 to
2d24c14
Compare
iliasbibas
changed the title
| @@ -81,7 +81,7 @@ const Joi: JoiWithExtensions = _Joi.extend( | |||
| base: joi.string().meta({baseType: 'string'}), | |||
| messages: {'objectId.invalid': 'Invalid objectId'}, | |||
| validate: (value, helpers) => { | |||
| return require('mongodb').ObjectId.isValid(value) | |||
| return require('mongoose').isValidObjectId(value) | |||
iliasbibas
force-pushed
the
change/PROD-34066-upgrade-mongo-7
branch
from
2d24c14 to
3839853
Compare
Added
mongoose@^7.6.7(latest 7.x) andmongodb@~5.9.1.The reason for upgrading
mongooseversion is its official support for MongoDB 7.Developers of apps using mongoose through orka should keep in mind the migration guide for any breaking changes in the apps.