Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEDX-695 : GHA OSS changes to sockjs_client_wrapper #67

Merged
merged 1 commit into from
Apr 3, 2024
Merged

FEDX-695 : GHA OSS changes to sockjs_client_wrapper #67

merged 1 commit into from
Apr 3, 2024

Conversation

alishadalal-wk
Copy link
Contributor

Summary

Finish migration to GHA.

  • Remove Dockerfile
  • Remove skynet.yaml
  • Generate an SBOM (see the guide)

Testing

  • CI passing
  • cyclone DX file attached as an artifact on the GHA build

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@alishadalal-wk alishadalal-wk marked this pull request as ready for review April 3, 2024 11:14
robbecker-wf
robbecker-wf approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 CI passes, cyclone file attached, required GHA set

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit b2337ed into master Apr 3, 2024
3 checks passed
@rmconsole7-wk rmconsole7-wk deleted the FEDX-695 branch April 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbecker-wf robbecker-wf robbecker-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@tusharmathur-wk tusharmathur-wk Awaiting requested review from tusharmathur-wk

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alishadalal-wk @aviary3-wk @robbecker-wf @rmconsole-wf @rmconsole7-wk