Improve code point parsing #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also throws a validation error when the codepoint could not be parsed
migacz1125
approved these changes
Oct 30, 2019
| return value.match(/^((0x[\d[a-f]+)|(\d+))$/gi) | ||
| } | ||
|
|
||
| function parseCodePoint(codePoint, propName) { |
There was a problem hiding this comment.
It is possible to consider parse value which ise recived from json outpu like '\f101' ?
Or maybe is possible to get json for icon-font-generator with js unicode like "\uf101' ?
There was a problem hiding this comment.
I've updated the code to support CSS unicode escape codes. I think this should do what you ask for.
There was a problem hiding this comment.
@Hammie really thank You for that. This is exactly what i wont.
migacz1125
approved these changes
Oct 31, 2019
| return value.match(/^((0x[\d[a-f]+)|(\d+))$/gi) | ||
| } | ||
|
|
||
| function parseCodePoint(codePoint, propName) { |
There was a problem hiding this comment.
@Hammie really thank You for that. This is exactly what i wont.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code point parsing to support unicode literals as value
Also throws a validation error when the codepoint could not be parsed
See issues #54 #56