-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to temporarily disable Glide hack while sneaking #919
base: master
Are you sure you want to change the base?
Conversation
This reverts commit fe8dadc.
WalkthroughWalkthroughThe GlideHack feature in a Java application has been updated to introduce a new option that allows users to temporarily disable the gliding function by crouching. This is achieved through a new setting that checks the player's crouch status and stops the glide accordingly when this setting is active. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/java/net/wurstclient/hacks/GlideHack.java (3 hunks)
Additional comments: 3
src/main/java/net/wurstclient/hacks/GlideHack.java (3)
22-34: The new
CheckboxSetting
doSneakFall
is well-named and includes a descriptive tooltip, which is good for user understanding.52-55: The addition of the
doSneakFall
setting to the constructor is correct and follows the existing pattern of adding settings.75-76: The conditional check for
doSneakFall
in theonUpdate
method is correctly implemented to return early if the player is sneaking.
woah this bot is cool |
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
still active, awaiting reviews |
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
... |
See #368, no more formatting issues and stuff.