Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonarcloud analysis issues #141

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

Purg
Copy link
Member

@Purg Purg commented Jan 30, 2024

Fixing now-failing SonarCloud analysis items.

No versions changed in this update.
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d479d6d) 99.87% compared to head (08652b2) 99.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          57       57           
  Lines        2311     2330   +19     
=======================================
+ Hits         2308     2327   +19     
  Misses          3        3           
Flag Coverage Δ
unittests 99.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Purg Purg force-pushed the dev/fix-sonarcloud-analysis-issues branch 2 times, most recently from 3d7df2b to 02760be Compare January 31, 2024 15:56
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Purg Purg marked this pull request as ready for review January 31, 2024 18:23
Copy link
Member

@brianhhu brianhhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The majority of changes seem to be due to how we originally used np.random, which have now been updated in this PR.

@brianhhu brianhhu merged commit 65bfa91 into XAITK:master Jan 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants