Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax setuptools build dependency #96

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Relax setuptools build dependency #96

merged 1 commit into from
Aug 23, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 23, 2023

Since setuptools is already on version 68.1.2.

@farmio
Copy link
Member

farmio commented Aug 23, 2023

Hi 👋!
I'm curious, why would this package be part of nxipkgs? What is the criteria for including one?
knx-frontend has no direct use. It is only intended to be installed from Home Assistant.

@tjni
Copy link
Contributor Author

tjni commented Aug 23, 2023

That's a great question. When it comes to Python packages, think of nixpkgs like PyPI with the following caveats:

  1. It usually only contains the latest version of each package.
  2. It builds from source (either from the PyPI sdist or from a version control).

If someone wants to package something (like Home Assistant) that depends on knx-frontend, then knx-frontend has to be packaged as well, just like how it would be on PyPI.

@farmio farmio merged commit 0893569 into XKNX:main Aug 23, 2023
2 checks passed
@farmio
Copy link
Member

farmio commented Aug 23, 2023

Oh dear, I hope no one tries to package HA with a package repo that only has the latest versions of everything 😬 it has so many dependencies - and all of them are pinned. On the other hand, I think it doesn't even require them in package, but installs on runtime via pip.

Anyway, good luck with your project!

@tjni tjni deleted the relax-setuptools branch August 23, 2023 06:22
@tjni
Copy link
Contributor Author

tjni commented Aug 23, 2023

Thank you very much for the well wishes! I think pinning is pretty great for an ecosystem like Home Assistant is. We've made the same choice in nixpkgs, which is to choose a single version instead of using a constraint solver to find some version. I expect we will sometimes have different versions, and then it's our responsibility to reconcile them. Sometimes, I imagine we will patch things locally, but I also intend to upstream changes when they make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants