-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLS-70d Credentials #5103
XLS-70d Credentials #5103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5103 +/- ##
=========================================
+ Coverage 77.7% 77.8% +0.2%
=========================================
Files 779 782 +3
Lines 66015 66614 +599
Branches 8156 8163 +7
=========================================
+ Hits 51261 51859 +598
- Misses 14754 14755 +1
|
d662782
to
eb0ff11
Compare
d388182
to
003c6ef
Compare
review fixes renamed malformedAuthorizedCredentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Nice job on this!
@ximinez this is ready to merge. Commit message:
|
Rippled PR: [here](XRPLF/rippled#5103)
Rippled PR: [here](XRPLF/rippled#5103)
Amendment: - Credentials New Transactions: - CredentialCreate - CredentialAccept - CredentialDelete Modified Transactions: - DepositPreauth - Payment - EscrowFinish - PaymentChannelClaim - AccountDelete New Object: - Credential Modified Object: - DepositPreauth API updates: - ledger_entry - account_objects - ledger_data - deposit_authorized Read full spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials
High Level Overview of Change
Implementation of Credentials feature. It extend usage of Deposit Authorization
Now account that require pre-authorization can setup DepositPreauth object with allowed credentials. And only accounts that have been authorized by the specified issuer (and get credentials from them) will be allowed to send the payments. Please check XLS-70d for detailed description of the feature.
Context of Change
CREDENTIAL
and its transactions -CredentialCreate, CredentialAccept, CredentialDelete
DEPOSIT_PREAUTH
ledger object updated to be able to use credentials. Updated transactions:DepositPreauth
,Payment, EscrowFinish, AccountDelete, PaymentChannelClaim
API Impact
deposit_authorized
addedcredentials
field.ledger_entry
addedauthorize_credentials
todeposit_preauth
field.ledger_entry
addedcredential
parameter.