Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage for ValidatorList #5116

Closed
wants to merge 1 commit into from

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Sep 2, 2024

High Level Overview of Change

Just another mildly interesting test case

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (2f432e8) to head (a4be0b5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5116   +/-   ##
=======================================
  Coverage     76.2%   76.2%           
=======================================
  Files          760     760           
  Lines        61489   61489           
  Branches      8115    8111    -4     
=======================================
+ Hits         46832   46842   +10     
+ Misses       14657   14647   -10     

see 3 files with indirect coverage changes

Impacted file tree graph

@Bronek Bronek marked this pull request as ready for review September 2, 2024 15:09
@Bronek
Copy link
Collaborator Author

Bronek commented Sep 3, 2024

Folded into #5112

@Bronek Bronek closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant