Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix macos unit tests #5192

Closed
wants to merge 5 commits into from
Closed

Conversation

oleks-rip
Copy link
Collaborator

@oleks-rip oleks-rip commented Nov 14, 2024

High Level Overview of Change

MACOS unit tests fix

Context of Change

Add retries to Env RPC requests to fix Macos disconnects during CI testing.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

  • No API impact

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (838978b) to head (146630d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5192     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          782     782             
  Lines        66621   66623      +2     
  Branches      8161    8138     -23     
=========================================
- Hits         51902   51895      -7     
- Misses       14719   14728      +9     

see 5 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:

@oleks-rip
Copy link
Collaborator Author

Attempt1
max retries observed

ripple.app.ValidatorRPC
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...
ERR:Env Env::do_rpc error, retrying...

@ximinez
Copy link
Collaborator

ximinez commented Nov 14, 2024

This is a duplicate of #5171

@oleks-rip
Copy link
Collaborator Author

oleks-rip commented Nov 14, 2024

This is a duplicate of #5171

Ohh, didn't saw that one.

UPDATE:
@ximinez Don't you find #5171 more heavier than it need to be?

@ximinez
Copy link
Collaborator

ximinez commented Nov 14, 2024

UPDATE: @ximinez Don't you find #5171 more heavier than it need to be?

It seems that way, but I ran into several edge cases and one-offs that made most of those changes necessary. Particularly to get the parallel tests working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants