Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add rpcName to LEDGER_ENTRY macro #5202

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Nov 22, 2024

High Level Overview of Change

The new LEDGER_ENTRY macro now takes one additional parameter, rpcName. This makes it easier to avoid missing including the new field in jss.h and to the list of account_objects/ledger_data filters.

Context of Change

Prevent easy bugs.

Type of Change

  • Refactor (non-breaking change that only restructures code)

API Impact

No change to the user.

Test Plan

All tests still pass.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (f64cf91) to head (ce95a00).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5202     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          784     784             
  Lines        66681   66681             
  Branches      8162    8139     -23     
=========================================
- Hits         51950   51941      -9     
- Misses       14731   14740      +9     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <100.0%> (ø)
src/libxrpl/protocol/LedgerFormats.cpp 100.0% <ø> (ø)
src/xrpld/rpc/detail/RPCHelpers.cpp 82.8% <ø> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

@mvadari
Copy link
Collaborator Author

mvadari commented Dec 2, 2024

Looks like Windows tests are failing. I'm not sure how to resolve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant