Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed version 2.3.0 #5204

Merged
merged 85 commits into from
Nov 25, 2024

Set version to 2.3.0

f64cf91
Select commit
Loading
Failed to load commit list.
Merged

Proposed version 2.3.0 #5204

Set version to 2.3.0
f64cf91
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

77.9% (target 60.0%)

View this Pull Request on Codecov

77.9% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 98.41689% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (68e1be3) to head (f64cf91).

Files with missing lines Patch % Lines
include/xrpl/beast/core/LexicalCast.h 85.7% 2 Missing ⚠️
include/xrpl/protocol/Asset.h 95.0% 2 Missing ⚠️
include/xrpl/protocol/Quality.h 94.4% 1 Missing ⚠️
include/xrpl/protocol/STNumber.h 66.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5204     +/-   ##
========================================
+ Coverage    71.1%   77.9%   +6.8%     
========================================
  Files         796     784     -12     
  Lines       67097   66679    -418     
  Branches    11012    8158   -2854     
========================================
+ Hits        47685   51916   +4231     
+ Misses      19412   14763   -4649     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.2% <ø> (ø)
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/ByteUtilities.h 100.0% <ø> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/CountedObject.h 100.0% <ø> (ø)
include/xrpl/basics/DecayingSample.h 88.6% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <100.0%> (ø)
include/xrpl/basics/FeeUnits.h 90.4% <100.0%> (ø)
include/xrpl/basics/IOUAmount.h 100.0% <100.0%> (ø)
include/xrpl/basics/LocalValue.h 100.0% <ø> (ø)
... and 140 more

... and 1287 files with indirect coverage changes

Impacted file tree graph