Skip to content

Add UNREACHABLE to LogicError

Codecov / codecov/project succeeded Jun 24, 2024 in 1s

71.3% (target 60.0%)

View this Pull Request on Codecov

71.3% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 75.27473% with 225 lines in your changes missing coverage. Please review.

Project coverage is 71.3%. Comparing base (ef02893) to head (4a6d7bd).

Current head 4a6d7bd differs from pull request most recent head a676c1a

Please upload reports for the commit a676c1a to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5042     +/-   ##
=========================================
- Coverage     71.3%   71.3%   -0.0%     
=========================================
  Files          796     796             
  Lines        66987   66900     -87     
  Branches     10892   10866     -26     
=========================================
- Hits         47793   47704     -89     
- Misses       19194   19196      +2     
Files Coverage Δ
src/ripple/app/consensus/RCLValidations.cpp 75.3% <100.0%> (ø)
src/ripple/app/ledger/AcceptedLedgerTx.cpp 100.0% <100.0%> (ø)
src/ripple/app/ledger/OrderBookDB.cpp 75.0% <100.0%> (ø)
src/ripple/app/ledger/impl/BuildLedger.cpp 91.2% <100.0%> (ø)
src/ripple/app/ledger/impl/LedgerDeltaAcquire.cpp 96.1% <100.0%> (ø)
src/ripple/app/ledger/impl/LedgerReplayTask.cpp 93.6% <100.0%> (ø)
src/ripple/app/ledger/impl/LedgerReplayer.cpp 89.6% <100.0%> (ø)
src/ripple/app/ledger/impl/SkipListAcquire.cpp 96.1% <100.0%> (ø)
src/ripple/app/ledger/impl/TimeoutCounter.cpp 86.2% <100.0%> (ø)
src/ripple/app/main/LoadManager.cpp 52.2% <100.0%> (ø)
... and 242 more

... and 1340 files with indirect coverage changes

Impacted file tree graph