-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMM support #344
Merged
Merged
Add AMM support #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in amm_info responses
… nk/amm-support
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
============================================
+ Coverage 90.50% 90.88% +0.38%
- Complexity 1504 1596 +92
============================================
Files 290 318 +28
Lines 4275 4489 +214
Branches 353 369 +16
============================================
+ Hits 3869 4080 +211
- Misses 281 282 +1
- Partials 125 127 +2
☔ View full report in Codecov by Sentry. |
… nk/amm-support
…ere is no empty or unset option
… nk/amm-support
Update existing AMM transactions with the latest formats. Remove any inference of flags based on fields because we're likely to get it wrong. Update AMM transaction flags with new values. Remove lsfAMM from AccountRootFlags and add AMMID to AccountRootObject.
sappenin
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this until the AMM amendment is endorsed on XRPL Mainnet
This PR adds support for XLS-30 AMMs.
New Transaction Types
AmmCreate
AmmDeposit
AmmBid
AmmVote
AmmWithdraw
AmmDelete
New Client Methods
XrplClient.ammInfo
callsamm_info
, takingAmmInfoRequestParams
as a parameter and returning anAmmInfoResult
Other Changes
Issue
(used to specifyAsset
andAsset2
in an AMM). This PR adds anIssue
type (calledIssueType
) to the binary codec module to encode/decode these values.AMM
ledger entry as well as theamm_info
result object. WhileAmmInfoResult.amm()
is very similar to theAMM
ledger entry, the rippled API formats the AMM object differently in responses toamm_info
. TheAmmObject
in this PR is basically inaccessible becauseXrplClient
doesn't support theledger_entry
RPC, but it will be good to have in the codebase once we add that method